feat: Add support for Japan Open Chain #464
Conversation
WalkthroughAdds two EVM network entries (japan-open-chain mainnet and japan-open-chain-testnet) to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/networks/other-l1s.json(10 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Redirect rules - openzeppelin-relayer
- GitHub Check: Header rules - openzeppelin-relayer
- GitHub Check: Pages changed - openzeppelin-relayer
- GitHub Check: boostsecurity - boostsecurityio/semgrep-pro
- GitHub Check: Analyze (rust)
- GitHub Check: semgrep/ci
🔇 Additional comments (16)
config/networks/other-l1s.json (16)
10-10: Gnosis: EIP-1559 flag looks correct.
LGTM.
27-33: Gnosis Chiado: formatting-only changes.
No semantic change detected.
39-49: Fantom mainnet: explorer URLs collapsed.
No issues.
63-66: Fantom testnet: RPC URL normalized.
Looks good.
75-82: Moonbeam: EIP-1559 flag present.
No concerns.
90-103: Moonriver: EIP-1559 flag present.
No concerns.
111-118: Moonbase: EIP-1559 flag + RPC.
LGTM.
122-134: Avalanche mainnet: explorer + EIP-1559.
LGTM.
142-150: Avalanche Fuji: EIP-1559 + deprecated tag.
LGTM.
154-166: Celo mainnet: explorer URLs collapsed.
LGTM.
182-184: Celo Alfajores: deprecated tag retained.
LGTM.
195-199: Celo Baklava: RPC + deprecated tag.
LGTM.
235-237: Aurora testnet: deprecated tag.
LGTM.
241-247: Fuse mainnet: EIP-1559 flag + RPC.
LGTM.
280-291: Japan Open Chain testnet: verify explorer URL and chain features.
- Explorer URL has a trailing slash; confirm downstream consumers handle both forms consistently.
- Verify EIP-1559 support and confirmations as above.
- Please add a link to the test transaction hash in the PR description for traceability.
265-278: Japan Open Chain mainnet — normalize RPC ports, trim whitespace, and verify EIP-1559 & confirmations.
- rpc-3 is missing the explicit port: change "https://rpc-3.japanopenchain.org" → "https://rpc-3.japanopenchain.org:8545" or document/verify why the port is omitted.
- Remove leading-space URL found elsewhere:
" https://rpc.fusespark.io".- Confirm whether JOC supports EIP-1559; if yes add
"features": ["eip1559"].- Sanity-check
required_confirmations = 1against chain finality; increase if the chain requires more confirmations for safe finality.File: config/networks/other-l1s.json (japan-open-chain entry).
| "explorer_urls": ["https://explorer.japanopenchain.org"], | ||
| "is_testnet": false, | ||
| "required_confirmations": 1, | ||
| "rpc_urls": [ |
There was a problem hiding this comment.
"features": [
"eip1559"
],
config/networks/other-l1s.json
Outdated
| "chain_id": 10081, | ||
| "explorer_urls": ["https://explorer.testnet.japanopenchain.org/"], | ||
| "is_testnet": true, | ||
| "required_confirmations": 1, |
There was a problem hiding this comment.
"features": [
"eip1559"
],
config/networks/other-l1s.json
Outdated
| "https://rpc-2.japanopenchain.org:8545", | ||
| "https://rpc-3.japanopenchain.org" | ||
| ], | ||
| "average_blocktime_ms": 10930, |
config/networks/other-l1s.json
Outdated
| "https://rpc-1.testnet.japanopenchain.org:8545", | ||
| "https://rpc-2.testnet.japanopenchain.org:8545" | ||
| ], | ||
| "average_blocktime_ms": 16200, |
There was a problem hiding this comment.
I grab that value from "Japan Open Chain stats" when I was coding. I now they say 5000, but even today it says 10.906s
There was a problem hiding this comment.
Same for the previous one. And there is no graph for that so we can find an average. Or should we stick to what they say?
config/networks/other-l1s.json
Outdated
| "https://rpc-2.testnet.japanopenchain.org:8545" | ||
| ], | ||
| "average_blocktime_ms": 16200, | ||
| "symbol": "JOC" |
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
config/networks/other-l1s.json (1)
259-259: Fuse Spark RPC URL whitespace fixed.Prior issue resolved; entry no longer has leading space. Thanks.
🧹 Nitpick comments (1)
config/networks/other-l1s.json (1)
276-276: Align or annotate average_blocktime_ms — value (5000 ms) conflicts with observed ~14.3s.Official docs don't publish a recommended block time; the block explorer reports ~14.3s average. Action: either set average_blocktime_ms to 14300 (ms) or remove the field; if retained, add provenance (e.g., "sourced from Japan Open Chain block explorer — retrieved YYYY‑MM‑DD") to avoid misleading ETAs.
File: config/networks/other-l1s.json — line 276
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/networks/other-l1s.json(10 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: boostsecurity - boostsecurityio/semgrep-pro
- GitHub Check: Redirect rules - openzeppelin-relayer
- GitHub Check: Header rules - openzeppelin-relayer
- GitHub Check: Pages changed - openzeppelin-relayer
- GitHub Check: Analyze (rust)
🔇 Additional comments (4)
config/networks/other-l1s.json (4)
10-10: Formatting-only tweaks look good.Inline arrays and minor list reflows introduce no semantic change. LGTM.
Also applies to: 27-33, 39-39, 63-65, 75-75, 79-79, 90-90, 111-111, 115-115, 122-123, 142-142, 146-148, 154-154, 242-242, 246-246, 254-255, 259-259
265-292: Guardrails: uniqueness and required fields verified.
Validation (JSON parse, duplicate chain_id/network, non-empty rpc_urls, required keys) ran against config/networks/other-l1s.json — no duplicates or missing fields found.
281-292: Testnet entry: confirm inheritance support; align fields for consistency.
- Is the custom field "from": "japan-open-chain" supported by the config loader? If not, it may be silently ignored.
- Consider mirroring features (e.g., ["eip1559"]) and adding required_confirmations (likely 1) for parity with mainnet.
- Minor nit: drop trailing slash in explorer URL for consistency with the rest.
Proposed diff:
{ - "from": "japan-open-chain", "type": "evm", "network": "japan-open-chain-testnet", "chain_id": 10081, - "explorer_urls": ["https://explorer.testnet.japanopenchain.org/"], + "explorer_urls": ["https://explorer.testnet.japanopenchain.org"], "is_testnet": true, + "required_confirmations": 1, "rpc_urls": [ "https://rpc-1.testnet.japanopenchain.org:8545", "https://rpc-2.testnet.japanopenchain.org:8545" ], + "features": ["eip1559"], "symbol": "JOCT" }Repo scan to verify "from" support (excludes JSON):
265-279: Japan Open Chain (mainnet) — add :8545 to rpc-3; confirm confirmations & avg block timeFile: config/networks/other-l1s.json Lines: 265-279
- rpc-3 is listed without :8545 but official endpoints show rpc-3 on port 8545 — apply diff below.
- Confirmed: chain_id = 81; EIP-1559 supported (London HF); explorer base URL correct.
- Not documented: average_blocktime_ms=5000 and required_confirmations=1. Measure average block time from the explorer API or remove/adjust; set confirmations per your risk policy (common: 1–3 for UX, 6–12+ for high-value transfers).
"rpc_urls": [ "https://rpc-1.japanopenchain.org:8545", "https://rpc-2.japanopenchain.org:8545", - "https://rpc-3.japanopenchain.org" + "https://rpc-3.japanopenchain.org:8545" ],
Summary
I have added the network configuration for
Japan Open Chainand tested it by sending transactions in testnet.Summary by CodeRabbit
New Features
Chores
Minor